Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the general esys tr context methods documentation. #373

Merged

Conversation

Superhepper
Copy link
Collaborator

#372 will still remain a problem in this PR.

@Superhepper Superhepper added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 19, 2022
@Superhepper Superhepper changed the title Imrpoves general esys tr context methods documentation. Improves the general esys tr context methods documentation. Sep 19, 2022
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

- Changed so that the doc test for 'nv_read' context method uses a
  different NV index TPM handle value. In order to easier debug
  if a handle leak is detected in the tests.

Signed-off-by: Jesper Brynolf <[email protected]>
- Changed the values of the NV index TPM handles for the general esys tr
  context method tests in order to make them unique.

Signed-off-by: Jesper Brynolf <[email protected]>
- Improves the documentation of the general esys tr context methods by
  add ing description of arguments and code examples.

Signed-off-by: Jesper Brynolf <[email protected]>
@ionut-arm ionut-arm merged commit f123b99 into parallaxsecond:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General esys tr context methods lacks proper documentation.
2 participants