Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 2021 edition #540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tmfink
Copy link
Contributor

@tmfink tmfink commented Aug 7, 2024

Resolves #516

Superhepper
Superhepper previously approved these changes Aug 7, 2024
Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am all for it. If necessary we can make the 7.x branch work for older edition.

@wiktor-k
Copy link
Collaborator

wiktor-k commented Aug 8, 2024

I'm also good 👍 but the TODO says we should take a look at the lints that were disabled... maybe that's something that you could look into @tmfink ? Thanks for your time! 🙇

ionut-arm
ionut-arm previously approved these changes Aug 8, 2024
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the change, but I also support @wiktor-k's query

Also avoid suppressing some lints

Signed-off-by: Travis Finkenauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rust edition.
4 participants