-
Notifications
You must be signed in to change notification settings - Fork 60
Fix Windows DLL boundary issues #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this problem. I have just a few points that I would like to be addressed.
Thanks @Superhepper I believe I have the changes ready! |
Now you just need to sign your commits and make sure that everything is properly formatted and it should pass all the checks. |
Updated, thanks! |
Just squash the changes into one commit and then you sign it. |
359eb58
to
766b898
Compare
Squashed. |
It seems as if you forgot to sign it. |
8f89be8
to
73d370c
Compare
Signed again :) |
I think it needs a sign off (not necessarily a GPG signsture). It's a different switch: |
Signed-off-by: Bryan D. Ashby <[email protected]>
73d370c
to
eb95e00
Compare
Signed off on this side |
On Windows, if DLL 'A' for example mallocs, it must be DLL 'A' that makes the free call in order to ensure the proper runtime. Currently Windows builds crash due to this problem. To reproduce (on Windows):
This MR uses
Esys_Free
to free allocated data. I may have missed some areas, so would love pointers. It's a bit tricky to test all the stuff here.