Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard set ‘Sponsored’ title on promo cards #343

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

jwade1327
Copy link
Member

@jwade1327 jwade1327 commented Jun 3, 2024

Screenshot 2024-06-03 at 10 45 35 AM Screenshot 2024-06-03 at 10 47 02 AM

@jwade1327 jwade1327 requested review from Shinsina and B77Mills June 3, 2024 14:36
@jwade1327
Copy link
Member Author

Copy link
Member

@Shinsina Shinsina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing it like this will require "developer intervention" (i.e a code change) every time they have an actual Sponsored campaign going, what should likely be done here is some sort of check to determine whether or not the returned node is actually a sponsored article or a "first party" promotion of some variety and render the appropriate information.

This will likely be easiest by doing a check against node.company.name for if it matches or is equivalent to Diverse Education i.e:

<if(get(node, 'company.name') === 'Diverse Education')>
<theme-standard-promo-node ...convertAdToNode(ads[0]) />
</if>
<else>
<!-- Whatever goes here --->
</else>

@jwade1327 jwade1327 requested a review from Shinsina June 3, 2024 15:50
@Shinsina Shinsina merged commit 689d08c into parameter1:master Jun 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants