Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extraneous custom compareRefs function #29

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

tombogle
Copy link
Contributor

@tombogle tombogle commented Aug 12, 2024

Changed code to use compareScrRefs from platform-bible-utils


This change is Reviewable

@tombogle tombogle requested a review from jolierabideau August 12, 2024 15:55
@tombogle tombogle self-assigned this Aug 12, 2024
jolierabideau
jolierabideau previously approved these changes Aug 12, 2024
Copy link
Contributor

@jolierabideau jolierabideau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)


package-lock.json line 115 at r1 (raw file):

        "@mui/material": ">=5.15.10",
        "@radix-ui/react-checkbox": "^1.0.4",
        "@radix-ui/react-dialog": "^1.1.1",

Interesting that these changes showed up in your PR! I guess someone didn't run npm i?

@tombogle
Copy link
Contributor Author

package-lock.json line 115 at r1 (raw file):

Previously, jolierabideau wrote…

Interesting that these changes showed up in your PR! I guess someone didn't run npm i?

I guess. Either that, or the versions are specified loosely enough that some later updates resulted in newer versions. I wasn't sure, but I went ahead and included them.

tjcouch-sil pushed a commit that referenced this pull request Oct 21, 2024
- also fix stylelint to work with tailwind @ directives
# Conflicts:
#	package-lock.json
#	src/paratext-bible-word-list/src/main.ts
Copy link
Contributor

@jolierabideau jolierabideau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom!

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tombogle)

@tombogle tombogle merged commit 4e64b97 into main Jan 14, 2025
3 checks passed
@tombogle tombogle deleted the compare-Scr-Refs branch January 14, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants