Add roctx support #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added roctx ranges around comms, and some important CG steps. Also added a build toggle to enable roctx support.
|
This is intended to fix #29 |
noelchalmers
requested changes
Apr 27, 2023
| @@ -115,7 +117,9 @@ int cg::Solve(solver_t& solver, | |||
| // x <= x + alpha*p | |||
| // r <= r - alpha*A*p | |||
| // dot(r,r) | |||
| if (MAXIT <= 100) roctxRangePush("cg::UpdateCG"); | |||
There was a problem hiding this comment.
It's a little surprising that you're annotating the MPI comms, and the CG update, but nothing else? Any reason the CG update is so special?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback on consuming ROCm location and the ensuing makefile infrastructure would be especially appreciated.