Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxwell solver example #90

Merged
merged 13 commits into from
Nov 29, 2023
Merged

Maxwell solver example #90

merged 13 commits into from
Nov 29, 2023

Conversation

tcew
Copy link
Contributor

@tcew tcew commented Sep 8, 2023

The Maxwell solver demos:

  1. TM mode 2D time-domain Maxwell's equation with homogeneous material on triangles.
  2. Full 3D time-domain Maxwell's equations with homogeneous material on tetrahedra.
  3. It does not currently include quads and hexes due to their additional requirements for spurious mode free simulations.
  4. The notation within the surface and volume kernels directly aligns with notation from the H&W book.
  5. The maxwell solver includes an L2 error estimate if activated, with consistent mass matrix based integration of the error at W&B nodes.

@tcew tcew requested a review from noelchalmers September 8, 2023 19:02
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #90 (75ec9d0) into staging (62efa57) will increase coverage by 0.09%.
Report is 1 commits behind head on staging.
The diff coverage is 91.12%.

❗ Current head 75ec9d0 differs from pull request most recent head 3a05adf. Consider uploading reports for the commit 3a05adf to get more accurate results

@@             Coverage Diff             @@
##           staging      #90      +/-   ##
===========================================
+ Coverage    86.19%   86.28%   +0.09%     
===========================================
  Files          285      293       +8     
  Lines        20092    20306     +214     
===========================================
+ Hits         17319    17522     +203     
- Misses        2773     2784      +11     
Files Coverage Δ
include/comm.hpp 100.00% <ø> (ø)
solvers/maxwell/maxwell.hpp 100.00% <100.00%> (ø)
solvers/maxwell/maxwellMain.cpp 100.00% <100.00%> (ø)
solvers/maxwell/src/maxwellRun.cpp 100.00% <100.00%> (ø)
solvers/maxwell/src/maxwellStep.cpp 100.00% <100.00%> (ø)
solvers/maxwell/src/maxwellSettings.cpp 97.22% <97.22%> (ø)
solvers/maxwell/src/maxwellReport.cpp 81.25% <81.25%> (ø)
solvers/maxwell/src/maxwellSetup.cpp 89.65% <89.65%> (ø)
solvers/maxwell/src/maxwellPlotFields.cpp 84.48% <84.48%> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@noelchalmers noelchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Made a couple tiny changes, and theres only a couple other things I noticed.

  • profilingTips.text - Do we need this?
  • The default problem size in setupTet3D.rc is real chunky, even for my workstation GPU. Maybe we can reduce this so it runs reasonably quickly?

@tcew
Copy link
Contributor Author

tcew commented Oct 16, 2023

Looks good. Made a couple tiny changes, and theres only a couple other things I noticed.

  • profilingTips.text - Do we need this?
  • The default problem size in setupTet3D.rc is real chunky, even for my workstation GPU. Maybe we can reduce this so it runs reasonably quickly?

I removed the profiling tips file and reduced the size of the box mesh in setupTet3D.rc

Are the testMaxwell.py meshes small enough ?

Copy link
Member

@noelchalmers noelchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@noelchalmers noelchalmers merged commit 7190faa into staging Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants