Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use after free errors #177

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Fix use after free errors #177

merged 8 commits into from
Jun 13, 2024

Commits on Jun 11, 2024

  1. Fix use after free errors

    Fixes a few cases where use after free could happen, and one where it can be
    easily reproduced.
    
    When using the FSEvents back-end, both the `Watcher` and a `State` pointers are
    passed as part of the context parameter to a C style callback.
    
    Both of these pointers may be free-ed before the callback is called before this
    commit.
    
    After this commit, these two pointers, as well as all most others in the
    codebase are replaced with `shared_ptr`.
    
    This is a lazy fix and goes against C++ core guidelines - "F.7".
    
    A secondary pass would use reference counting only in the shared ownership
    cases. For most back-ends this shared ownership happens on: error types,
    subscription maps/sets and state structs.
    yamadapc committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8a1d019 View commit details
    Browse the repository at this point in the history
  2. Fix memory errors

    yamadapc committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    c8c7c8e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f03a752 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ad6a70 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    81500c1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    46c4695 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7eb5427 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Configuration menu
    Copy the full SHA
    b31c591 View commit details
    Browse the repository at this point in the history