-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use after free errors #177
Merged
Merged
Commits on Jun 11, 2024
-
Fixes a few cases where use after free could happen, and one where it can be easily reproduced. When using the FSEvents back-end, both the `Watcher` and a `State` pointers are passed as part of the context parameter to a C style callback. Both of these pointers may be free-ed before the callback is called before this commit. After this commit, these two pointers, as well as all most others in the codebase are replaced with `shared_ptr`. This is a lazy fix and goes against C++ core guidelines - "F.7". A secondary pass would use reference counting only in the shared ownership cases. For most back-ends this shared ownership happens on: error types, subscription maps/sets and state structs.
Configuration menu - View commit details
-
Copy full SHA for 8a1d019 - Browse repository at this point
Copy the full SHA 8a1d019View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8c7c8e - Browse repository at this point
Copy the full SHA c8c7c8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f03a752 - Browse repository at this point
Copy the full SHA f03a752View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad6a70 - Browse repository at this point
Copy the full SHA 6ad6a70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81500c1 - Browse repository at this point
Copy the full SHA 81500c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c4695 - Browse repository at this point
Copy the full SHA 46c4695View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eb5427 - Browse repository at this point
Copy the full SHA 7eb5427View commit details
Commits on Jun 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b31c591 - Browse repository at this point
Copy the full SHA b31c591View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.