Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try separated workflow #35

Merged
merged 18 commits into from
Jan 17, 2025
Merged

feat: try separated workflow #35

merged 18 commits into from
Jan 17, 2025

Conversation

kpplis
Copy link
Contributor

@kpplis kpplis commented Jan 17, 2025

No description provided.

@github-actions github-actions bot added the ci label Jan 17, 2025
@kpplis kpplis marked this pull request as ready for review January 17, 2025 10:29
@kpplis kpplis requested a review from a team as a code owner January 17, 2025 10:29
@andibeuge
Copy link
Contributor

Maybe rename the "build" to "container-image-build"

@kpplis kpplis changed the title try separated workflow refactor: try separated workflow Jan 17, 2025
@kpplis
Copy link
Contributor Author

kpplis commented Jan 17, 2025

Maybe rename the "build" to "container-image-build"

@andibeuge I think build-image is better: we only build containers anyway. Are you good with it?

@kpplis
Copy link
Contributor Author

kpplis commented Jan 17, 2025

For some reason linter complains about initialize step name, which is defined same as before

@kpplis kpplis requested a review from andibeuge January 17, 2025 11:35
@andibeuge andibeuge changed the title refactor: try separated workflow feat: try separated workflow Jan 17, 2025
@kpplis kpplis merged commit 6641465 into main Jan 17, 2025
6 checks passed
@kpplis kpplis deleted the separate-build-step branch January 17, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmpalomares jmpalomares jmpalomares approved these changes

@andibeuge andibeuge andibeuge approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpplis @andibeuge @jmpalomares