Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct cache-from for ECR builds, make container scan optional #36

Merged
merged 9 commits into from
Jan 27, 2025
Merged

fix: correct cache-from for ECR builds, make container scan optional #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f73e380
fix: correct cache-from for ECR builds
andibeuge Jan 23, 2025
3e38eb7
fix: correct cache-from for ECR builds
andibeuge Jan 23, 2025
862c3b3
fix: disable containerscan temporary for ecr-single
andibeuge Jan 23, 2025
dfc3384
fix: disable containerscan temporary for ecr-single
andibeuge Jan 23, 2025
7f6c2bf
fix: linted, updated packages
andibeuge Jan 24, 2025
d89ec24
fix: make container scan toggable
andibeuge Jan 27, 2025
2bd6043
fix: moved variable to context
andibeuge Jan 27, 2025
a72635a
fix: pipeline ref updated
andibeuge Jan 27, 2025
983f437
Update .github/workflows/kubernetes.yaml
andibeuge Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/build-image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ on:
description: The kind of repository (github or ecr)
default: "github"
type: string
enableContainerScan:
required: false
description: Apply the container scan
default: true
type: boolean
runner:
required: false
description: Runner type
Expand Down Expand Up @@ -106,6 +111,7 @@ jobs:
${{ inputs.registryHostname }}/${{ inputs.registryOrg }}/${{ github.event.deployment.payload.name }}:${{ inputs.version }}
${{ inputs.registryHostname }}/${{ inputs.registryOrg }}/${{ github.event.deployment.payload.name }}:${{ github.sha }}
- name: Scan for vulnerabilities
if: inputs.enableContainerScan
uses: crazy-max/ghaction-container-scan@v3
with:
image: ${{ inputs.registryHostname }}/${{ inputs.registryOrg }}/${{ github.event.deployment.payload.name }}:latest
Expand Down Expand Up @@ -166,7 +172,7 @@ jobs:
APP_NAME=${{ github.event.deployment.payload.name }}
ENVIRONMENT=${{ github.event.deployment.payload.env }}
NPM_GITHUB_TOKEN=${{ secrets.npmGithubReadToken }}
cache-from: type=registry,ref=${{ inputs.registryHostname }}/${{ inputs.registryOrg }}/${{ github.event.deployment.payload.name }}
cache-from: type=registry,ref=${{ inputs.registryHostname }}/${{ github.event.deployment.payload.name }}
cache-to: type=inline
context: ${{ github.event.deployment.payload.container.context }}
load: true
Expand All @@ -177,7 +183,7 @@ jobs:
${{ steps.login-ecr.outputs.registry }}/${{ github.event.deployment.payload.name }}:${{ inputs.version }}
${{ steps.login-ecr.outputs.registry }}/${{ github.event.deployment.payload.name }}:${{ github.sha }}
- name: Scan for vulnerabilities
if: inputs.repository_kind == 'ecr'
if: inputs.enableContainerScan
uses: crazy-max/ghaction-container-scan@v3
with:
image: ${{ steps.login-ecr.outputs.registry }}/${{ github.event.deployment.payload.name }}:latest
Expand Down Expand Up @@ -245,6 +251,7 @@ jobs:
target: ${{ matrix.containerfile_targets }}
- name: Scan for vulnerabilities
uses: crazy-max/ghaction-container-scan@v3
if: inputs.enableContainerScan
with:
image: ${{ inputs.registryHostname }}/${{ inputs.registryOrg }}/${{ github.event.deployment.payload.name }}-${{ matrix.containerfile_targets }}:latest
dockerfile: Containerfile
Expand Down Expand Up @@ -306,7 +313,7 @@ jobs:
APP_NAME=${{ github.event.deployment.payload.name }}
ENVIRONMENT=${{ github.event.deployment.payload.env }}
NPM_GITHUB_TOKEN=${{ secrets.npmGithubReadToken }}
cache-from: type=registry,ref=${{ inputs.registryHostname }}/${{ inputs.registryOrg }}/${{ github.event.deployment.payload.name }}
cache-from: type=registry,ref=${{ inputs.registryHostname }}/${{ github.event.deployment.payload.name }}
cache-to: type=inline
context: ${{ github.event.deployment.payload.container.context }}
load: true
Expand All @@ -318,6 +325,7 @@ jobs:
${{ steps.login-ecr.outputs.registry }}/${{ github.event.deployment.payload.name }}-${{ matrix.containerfile_targets }}:${{ github.sha }}
target: ${{ matrix.containerfile_targets }}
- name: Scan for vulnerabilities
if: inputs.enableContainerScan
uses: crazy-max/ghaction-container-scan@v3
with:
image: ${{ steps.login-ecr.outputs.registry }}/${{ github.event.deployment.payload.name }}-${{ matrix.containerfile_targets }}:latest
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/kubernetes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ on:
description: The kind of repository (github or ecr)
default: "github"
type: string
enableContainerScan:
required: false
description: Apply the container scan
default: true
type: boolean
runner:
required: false
description: Runner type
Expand Down Expand Up @@ -183,6 +188,7 @@ jobs:
registryOrg: ${{ inputs.registryOrg }}
registryUsername: ${{ inputs.registryUsername }}
repository_kind: ${{ inputs.repository_kind }}
enableContainerScan: ${{ inputs.enableContainerScan }}
runner: ${{ inputs.runner }}
version: ${{ needs.initialize.outputs.version }}
secrets: inherit
Expand Down
65 changes: 34 additions & 31 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading