benchmark: expose used namespace as CLI argument #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilpner
force-pushed
the
benchmark-cli-namespace
branch
from
914d084 to
349fdce
Compare
tilpner
force-pushed
the
benchmark-cli-namespace
branch
from
349fdce to
91d8cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to using a user-provided namespace during benchmarking, instead of a constant "benchmark". This means it's now possible to execute two benchmark instances in parallel, without them interfering with each other (otherwise the server will crash currently).
Now, there's probably no good reason to support this for benchmarking purposes, as the numbers won't be reliable for single-client usecases, and it's not convenient to start multiple benchmarks and aggregate results for this to be usable for multi-client benchmarks. And it's incomplete, only the object benchmarks are adapted to use the new parameter.
It's only real usecase is hammering a backend with multiple clients, without them interfering with each other, so feel free to close if that's not something you want julea-benchmark to do.