feat: use gnome's nightlight api on gnome desktop #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dus-nightlight work on Gnome wayland as well)
|
We wrote the application only for xfce and it is installed by default only in xfce. Because gnome already has its own built-in night light integration. Still, your idea is good, but it seems problematic in its current form. You need to test it more thoroughly and fix it. Also, full gnome compatibility is required. |
what is the problematic part? |
…of ui_night_switch
|
@fthaltun it should be fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make pardus-nightlight work on Gnome wayland as well