Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add docker worker #374

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

glemaitre
Copy link
Collaborator

closes #290

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #374 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
- Coverage   93.36%   92.83%   -0.54%     
==========================================
  Files          99       95       -4     
  Lines        8248     7549     -699     
==========================================
- Hits         7701     7008     -693     
+ Misses        547      541       -6     
Impacted Files Coverage Δ
ramp-utils/ramp_utils/ramp_cli.py 0.00% <0.00%> (-64.94%) ⬇️
ramp-database/ramp_database/utils.py 89.65% <0.00%> (-10.35%) ⬇️
ramp-database/ramp_database/testing.py 93.12% <0.00%> (-6.88%) ⬇️
ramp-engine/ramp_engine/base.py 92.15% <0.00%> (-3.30%) ⬇️
ramp-frontend/ramp_frontend/views/leaderboard.py 27.52% <0.00%> (-3.18%) ⬇️
ramp-frontend/ramp_frontend/views/ramp.py 72.57% <0.00%> (-1.44%) ⬇️
ramp-database/ramp_database/cli.py 96.64% <0.00%> (-0.86%) ⬇️
ramp-frontend/ramp_frontend/views/general.py 96.87% <0.00%> (-0.80%) ⬇️
ramp-frontend/ramp_frontend/views/admin.py 84.76% <0.00%> (-0.59%) ⬇️
ramp-database/ramp_database/model/submission.py 97.08% <0.00%> (-0.29%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e975d0...8072292. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jan 26, 2020

Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 69:80: E501 line too long (81 > 79 characters)

Comment last updated at 2020-10-16 13:54:15 UTC

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2020

This pull request introduces 6 alerts and fixes 3 when merging 5534c9d into a13643d - view on LGTM.com

new alerts:

  • 3 for Unused local variable
  • 3 for 'super' in old style class

fixed alerts:

  • 3 for 'super' in old style class

@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2020

This pull request introduces 5 alerts and fixes 3 when merging cf56bf0 into c7a3562 - view on LGTM.com

new alerts:

  • 3 for 'super' in old style class
  • 2 for Unused local variable

fixed alerts:

  • 3 for 'super' in old style class

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2020

This pull request introduces 2 alerts when merging 8072292 into 7e975d0 - view on LGTM.com

new alerts:

  • 2 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run evaluation in Docker
3 participants