Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up size limit for data in submission_file_types #578

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

frcaud
Copy link
Collaborator

@frcaud frcaud commented Jun 17, 2022

Up the size limit for data in submission_file_types, mainly to upload bigger weights files for NN (from 100M to 1G)

@rth
Copy link
Collaborator

rth commented Jun 17, 2022

I'm not sure it would have any effect for us though, as this is only used when initiallizing the DB, I think? For an existing DB we need to change the value in the DB directly.

@frcaud
Copy link
Collaborator Author

frcaud commented Jun 17, 2022

I also changed value of max_size in DB directly and it solves our pb
Thanks for your help @rth !

@agramfort
Copy link
Collaborator

@frcaud tests complain

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #578 (db1bcb9) into master (ccf2cf5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         103      103           
  Lines        8964     8964           
=======================================
  Hits         8384     8384           
  Misses        580      580           
Impacted Files Coverage Δ
ramp-database/ramp_database/testing.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf2cf5...db1bcb9. Read the comment docs.

@frcaud
Copy link
Collaborator Author

frcaud commented Jun 20, 2022

CIs are green !

@agramfort
Copy link
Collaborator

I am surprised you have to modify things just here. You have references elsewhere to the 100MB limit eg in test and maybe in the doc ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants