-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperopts #313
base: master
Are you sure you want to change the base?
Hyperopts #313
Conversation
…-Ark/libraries/ramp-workflow into hyperopts
…-Ark/libraries/ramp-workflow into hyperopts
This reverts commit a4130e2.
…Ark/libraries/ramp-workflow into hyperopts
Trying to let sphynx<4.0 go because of test error sphinx-doc/sphinx#10291
Codecov ReportBase: 83.15% // Head: 75.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 83.15% 75.69% -7.46%
==========================================
Files 137 139 +2
Lines 4748 4855 +107
==========================================
- Hits 3948 3675 -273
- Misses 800 1180 +380
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It seems windows tests are failing because of the netcdf library, @rth do you have any suggestion what to do? |
CI fails because there are no binary wheels for Python 3.6 and 3.7 for netcdf4 and it misses the headers to build it from sources (which is particularly difficult on Windows). What we could do is either,
BTW, if possible it might be better to keep ray an optional dependency as itself it has a lot of dependencies (particularly if we don't need it to run submissions on the ramp-board server) |
@rth @kegl any idea on how to solve this new error ? import file mismatch: |
Do you see the error when you run pytest locally on your machine? It seems this error was generated when you added the hyperopt test, no? Maybe some globals are clashing with other tests, like PATH? |
What I propose is to let this error stay for now. @SofianChay will work on the time series tools in the next months, one of the goals is to get rid of netcfd and replace the test with a simpler use case using csvs. |
Awesome, that is exactly what I had in mind but don't know how to do it. Yes, ramp-hyperopt is optional, not needed for the server, so we should make ray tune import also optional. @rth Can you do this once @martin1tab fixes the new clash? |
@martin1tab We noticed that there were a lot of formatting changes unrelated to the PR (' to ", to mention one; the convention on RAMP is single quote). Pls take these off the PR. |
This PR modifies the following in ramp hyperopt: