Lock memory map when reading from file #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheme
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Make sense.
I remember having issues testing the grow method of windows on a linux and my code at the time was droping before creating but I think it solve nothing in this case the lock looks needed.
Just wondering if the lock is stricly linux when using linux grow method (overall seems safer to have it)?
|
I'll run it for longer, but memory usage on Windows with this patch looks very promising so far |
|
I have a high degree of confidence this fixes #233. Previously in less than an hour it was crashing, now I don't see any indication of the problem happening at all. Would be awesome to get this in a patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #233