-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run CI checks on draft PR #7168
Comments
For GHA, example. |
CC @alvicsam |
Why should CI checks be disabled for draft PRs? |
50 error messages on a push is certainly too much. people should run tests locally anyway |
Wait, how do these error messages look? Maybe we should instead make it less spammy? |
I agree.
You are one of the few that does this. Most contributors, even maintainers will do incremental pushes straight to PR during development without locally running any tests, and will only start looking at tests and CI at the very end, when they are ready for review. I hope we can at least we can standardize a process of doing dev in "draft" mode, then only mark PR as ready after it is (at least mostly) ready with tests passing on dev's machine. CI would only run for "ready" PRs, and not Drafts. |
I got >50 CI errors on my draft PR, which is pointless. CI checks should be disabled for draft PR.
The text was updated successfully, but these errors were encountered: