Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run CI checks on draft PR #7168

Open
xlc opened this issue Jan 15, 2025 · 7 comments · May be fixed by #7518
Open

Don't run CI checks on draft PR #7168

xlc opened this issue Jan 15, 2025 · 7 comments · May be fixed by #7518

Comments

@xlc
Copy link
Contributor

xlc commented Jan 15, 2025

I got >50 CI errors on my draft PR, which is pointless. CI checks should be disabled for draft PR.

@aurexav
Copy link
Contributor

aurexav commented Jan 15, 2025

For GHA, example.

@bkchr
Copy link
Member

bkchr commented Jan 15, 2025

CC @alvicsam

@alvicsam alvicsam linked a pull request Feb 10, 2025 that will close this issue
@mutantcornholio
Copy link
Contributor

mutantcornholio commented Feb 10, 2025

Why should CI checks be disabled for draft PRs?
If I see CI failing, I move the PR to draft (so it wouldn't get reviewed in the meantime) and fix it until CI's green.

@xlc
Copy link
Contributor Author

xlc commented Feb 10, 2025

50 error messages on a push is certainly too much. people should run tests locally anyway

@mutantcornholio
Copy link
Contributor

Wait, how do these error messages look? Maybe we should instead make it less spammy?
IMO, checks should just be red, with all the info inside, they shouldn't be sending messages.

@xlc
Copy link
Contributor Author

xlc commented Feb 11, 2025

Image

I guess this relates to personal settings as I configured to receive notifications on failed CI run and there are bunch of them configured in this repo.

majority of the CI run are waste of compute on draft PR anyway

@acatangiu
Copy link
Contributor

acatangiu commented Feb 11, 2025

majority of the CI run are waste of compute on draft PR anyway

I agree.

If I see CI failing, I move the PR to draft (so it wouldn't get reviewed in the meantime) and fix it until CI's green.

You are one of the few that does this. Most contributors, even maintainers will do incremental pushes straight to PR during development without locally running any tests, and will only start looking at tests and CI at the very end, when they are ready for review.
In the meantime all those incremental pushes just uselessly burn a lot of electricity/money.

I hope we can at least we can standardize a process of doing dev in "draft" mode, then only mark PR as ready after it is (at least mostly) ready with tests passing on dev's machine. CI would only run for "ready" PRs, and not Drafts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants