Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run CI on draft PRs #7518

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ci: don't run CI on draft PRs #7518

wants to merge 4 commits into from

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Feb 10, 2025

PR adjusts gtihub workflow so they don't run on draft PRs. There was also an idea to trigger CI in a draft state using label but after experiments I decided not to implement it. The main reason is that any label change will trigger workflows.

close https://github.com/paritytech/ci_cd/issues/1099
close #7168

@alvicsam alvicsam marked this pull request as ready for review February 10, 2025 13:03
@alvicsam alvicsam requested review from a team as code owners February 10, 2025 13:03
@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Feb 10, 2025
@alvicsam alvicsam changed the title [WIP]ci: don't run CI on draft PRs ci: don't run CI on draft PRs Feb 10, 2025
@mutantcornholio
Copy link
Contributor

mutantcornholio commented Feb 10, 2025

A lot of times I actually create draft PRs specifically to run CI.
Also, if CI's failing and I need to fix it, I move the PR to draft, so it wouldn't get reviewed, as it'll be changed anyway.
Why do we want to do this anyway? UPD: I've read the issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run CI checks on draft PR
3 participants