Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kusama and polkadot SP constants from parachains-common #2666

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Remove kusama and polkadot SP constants from parachains-common #2666

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba85c93
Remove kusama and polkadot SP constants from parachains-common
seadanda Dec 8, 2023
2afe807
Remove reference to polkadot accounts in collectives-westend
seadanda Dec 12, 2023
686f38a
Merge branch 'master' into donal-mv-sp-common-fellowship
seadanda Dec 12, 2023
1415825
Merge branch 'master' into donal-mv-sp-common-fellowship
seadanda Dec 13, 2023
32869a4
Add prdoc
seadanda Dec 13, 2023
14f8ae8
Merge branch 'master' into donal-mv-sp-common-fellowship
seadanda Jan 3, 2024
eca98ee
Fix people chain treasury pallet id
seadanda Jan 4, 2024
6c8e9c5
Merge branch 'master' into donal-mv-sp-common-fellowship
seadanda Jan 4, 2024
dc3082b
Update prdoc/pr_2666.prdoc
seadanda Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 0 additions & 122 deletions cumulus/parachains/common/src/kusama.rs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions cumulus/parachains/common/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
#![cfg_attr(not(feature = "std"), no_std)]

pub mod impls;
pub mod kusama;
pub mod message_queue;
pub mod polkadot;
pub mod rococo;
pub mod westend;
pub mod wococo;
Expand Down
144 changes: 0 additions & 144 deletions cumulus/parachains/common/src/polkadot.rs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion cumulus/parachains/runtimes/people/people-rococo/src/people.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ parameter_types! {
pub const ByteDeposit: Balance = deposit(0, 1);
pub const SubAccountDeposit: Balance = deposit(1, 53);
pub RelayTreasuryAccount: AccountId =
parachains_common::polkadot::account::POLKADOT_TREASURY_PALLET_ID.into_account_truncating();
parachains_common::TREASURY_PALLET_ID.into_account_truncating();
}

impl pallet_identity::Config for Runtime {
Expand Down
2 changes: 1 addition & 1 deletion cumulus/parachains/runtimes/people/people-westend/src/people.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ parameter_types! {
pub const ByteDeposit: Balance = deposit(0, 1);
pub const SubAccountDeposit: Balance = deposit(1, 53);
pub RelayTreasuryAccount: AccountId =
parachains_common::polkadot::account::POLKADOT_TREASURY_PALLET_ID.into_account_truncating();
parachains_common::TREASURY_PALLET_ID.into_account_truncating();
}

impl pallet_identity::Config for Runtime {
Expand Down
14 changes: 14 additions & 0 deletions prdoc/pr_2666.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Remove kusama and polkadot SP constants from parachains-common

doc:
- audience: Runtime Dev
description: |
The constants for System Parachains in Kusama and Polkadot are now added to a new package in
the fellowship repo. This PR removes them from Polkadot-SDK. They are now accessible from the
system-parachains-constants package.
seadanda marked this conversation as resolved.
Show resolved Hide resolved

crates:
- name: parachains-common