Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates: add genesis config presets for minimal/solochain #5868

Merged

Conversation

iulianbarbu
Copy link
Contributor

@iulianbarbu iulianbarbu commented Sep 30, 2024

Description

Closes #5790. Useful for starting nodes based on minimal/solochain when doing development or for testing omni node with less happy code paths. It is reusing the presets defined for the nodes chain specs.

Integration

Specifically useful for development/testing if generating chain-specs for minimal or solochain runtimes from templates directories.

Review Notes

Added genesis_config_presets modules for both minimal/solochain. I reused the presets defined in each node chain_spec module correspondingly.

PRDOC

Not sure who uses templates, maybe node devs and runtime devs at start of their learning journey, but happy to get some guidance on how to write the prdoc if needed.

Thinking out loud

I saw concerns around sharing functionality for such genesis config presets between the template chains. I think there might be a case for doing that, on the lines of this comment: #4739 (comment). I would add that parachains-common::genesis_config_heleper contains a few methods from those mentioned, but I am unsure if using it as a dependency for templates is correct. Feels like the comment suggests there should be a commons crate concerning just templates, which I agree with to some degree, if we assume cumulus needs might be driven in certain directions that are not relevant to templates and vice versa. However I am not so certain about this, so would welcome some thoughts, since I am seeing parachains-common being used already in a few runtime implementations: https://crates.io/crates/parachains-common/reverse_dependencies?page=3, so might be a good candidate already for the common logic.

@iulianbarbu iulianbarbu added the R0-silent Changes should not be mentioned in any release notes label Sep 30, 2024
@iulianbarbu iulianbarbu self-assigned this Sep 30, 2024
@iulianbarbu iulianbarbu added the T17-Templates This PR/Issue is related to templates label Sep 30, 2024
Signed-off-by: Iulian Barbu <[email protected]>
@iulianbarbu iulianbarbu changed the title Add genesis config presets for minimal/solochain templates: add genesis config presets for minimal/solochain Sep 30, 2024
@michalkucharczyk
Copy link
Contributor

Regarding #4739 (comment)

Do we really need these functions? They look like some generic wrappers around sp-core/crypto types (or some related low level crate). Maybe they can be easily translated to some readable form. If not, maybe they should be moved there.

@bkontur
Copy link
Contributor

bkontur commented Oct 1, 2024

Regarding #4739 (comment)

Do we really need these functions? They look like some generic wrappers around sp-core/crypto types (or some related low level crate). Maybe they can be easily translated to some readable form. If not, maybe they should be moved there.

@michalkucharczyk this is (partially) addressed here: #5705 and almost done here: #5804

@iulianbarbu
Copy link
Contributor Author

I agree with @bkontur , maybe we can push on integrating the common methods somewhere more nicely and useful so that we can use them without duplication. Probably #5804 is the best candidate to do part of this change, if not the most important one.

Signed-off-by: Iulian Barbu <[email protected]>
@iulianbarbu iulianbarbu requested a review from skunert October 1, 2024 16:14
Signed-off-by: Iulian Barbu <[email protected]>
@iulianbarbu iulianbarbu enabled auto-merge October 2, 2024 09:48
@iulianbarbu iulianbarbu added this pull request to the merge queue Oct 5, 2024
Merged via the queue into paritytech:master with commit f8807d1 Oct 5, 2024
205 of 206 checks passed
@iulianbarbu iulianbarbu deleted the ib-add-genesis-config-presets branch October 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T17-Templates This PR/Issue is related to templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GenesisConfig presets for templates runtimes (minimal and solochain)
4 participants