Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove riscv feature flag #6305

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Remove riscv feature flag #6305

merged 8 commits into from
Oct 31, 2024

Conversation

athei
Copy link
Member

@athei athei commented Oct 30, 2024

Since #6266 we no longer require a custom toolchain to build the pallet-revive-fixtures. Hence we no longer have to guard the build behind a feature flag.

@athei athei added T7-smart_contracts This PR/Issue is related to smart contracts. T10-tests This PR/Issue is related to tests. labels Oct 30, 2024
@athei athei requested review from a team as code owners October 30, 2024 20:28
@athei athei requested review from pgherveou, xermicus and mordamax and removed request for a team and pgherveou October 30, 2024 20:31
@athei
Copy link
Member Author

athei commented Oct 30, 2024

/cmd prdoc --audience runtime_dev --bump major

Copy link
Contributor

@pgherveou pgherveou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance

Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fingers crossed the 64bit target support lands soon too

@athei athei enabled auto-merge October 31, 2024 11:38
@athei athei added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit dd9924f Oct 31, 2024
196 of 198 checks passed
@athei athei deleted the at/remove-feature branch October 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T7-smart_contracts This PR/Issue is related to smart contracts. T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants