Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes cfg attributes in runtime macro #6410

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Fixes cfg attributes in runtime macro #6410

merged 5 commits into from
Nov 25, 2024

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Nov 7, 2024 •
edited
Loading

Fixes #6209

This PR adds the support for cfg attributes in the runtime macro.

@gupnik gupnik added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Nov 7, 2024
@gupnik gupnik requested a review from a team as a code owner November 7, 2024 16:10
@gupnik gupnik requested a review from gui1117 November 7, 2024 16:11
bkchr
bkchr approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the disable metadata stuff, it looks good.

substrate/frame/support/procedural/src/runtime/parse/mod.rs Outdated Show resolved Hide resolved
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/11952225824
Failed job name: test-linux-stable-no-try-runtime

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/11952225824
Failed job name: test-linux-stable-runtime-benchmarks

@gupnik gupnik changed the title Fixes cfg attributes in runtime macro and adds disable_metadata Fixes cfg attributes in runtime macro Nov 25, 2024
@gupnik gupnik added the R0-silent Changes should not be mentioned in any release notes label Nov 25, 2024
@gupnik gupnik added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 6da7d36 Nov 25, 2024
191 of 198 checks passed
@gupnik gupnik deleted the gupnik/runtime-cfg branch November 25, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FRAME: runtime macro doesn't handle cfg contrary to construct_runtime
3 participants
@gupnik @bkchr @gui1117