Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-assets-freezer to umbrella crate #6599

Merged
merged 32 commits into from
Jan 20, 2025

Conversation

runcomet
Copy link
Contributor

@runcomet runcomet commented Nov 21, 2024

Part of #6504

Added modules

  • utility: Traits not tied to any direct operation in the runtime.

polkadot address: 14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 21, 2024

User @runcomet, please sign the CLA here.

@runcomet runcomet marked this pull request as ready for review November 23, 2024 03:11
@runcomet runcomet requested a review from a team as a code owner November 23, 2024 03:11
@runcomet
Copy link
Contributor Author

runcomet commented Dec 7, 2024

please review @re-gius

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Dec 9, 2024
@runcomet
Copy link
Contributor Author

please review @re-gius

@re-gius
Copy link
Contributor

re-gius commented Jan 3, 2025

from the guidelines

//! * The currency related traits are kept out of the preludes to encourage a deliberate choice of
//! one over the other.

pub use sp_runtime::traits::{IdentifyAccount, IdentityLookup};
}

/// Utility traits not tied to any direct operation in the runtime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Utility traits not tied to any direct operation in the runtime.
/// Utility traits not tied to any direct operation in the runtime.
///
/// This is already part of the [`prelude`].

Cargo.lock Outdated
@@ -1396,7 +1396,7 @@ dependencies = [
"futures-lite 2.3.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes to this file

Copy link
Contributor Author

@runcomet runcomet Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you mean? It's on main.

"futures-lite 2.3.0",

@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 13, 2025 23:24
Copy link
Contributor

@re-gius re-gius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frame-benchmarking = { optional = true, workspace = true }
frame-support = { workspace = true }
frame-system = { workspace = true }
frame = { workspace = true, features = ["experimental", "runtime"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are removing the experimental feature flag as in #7177 to avoid spreading that feature to the whole sdk.

Suggested change
frame = { workspace = true, features = ["experimental", "runtime"] }
frame = { workspace = true, features = ["runtime"] }

Copy link
Contributor Author

@runcomet runcomet Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for all open PRs @re-gius

@re-gius re-gius added this pull request to the merge queue Jan 20, 2025
@re-gius
Copy link
Contributor

re-gius commented Jan 20, 2025

/tip small

Copy link

@re-gius A referendum for a small (20 DOT) tip was successfully submitted for @runcomet (14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg on polkadot).

Referendum number: 1396.
tip

Copy link

The referendum has appeared on Polkassembly.

Merged via the queue into paritytech:master with commit 711e6ff Jan 20, 2025
193 of 205 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants