-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pallet-assets-freezer
to umbrella crate
#6599
Conversation
please review @re-gius |
please review @re-gius |
from the guidelines polkadot-sdk/substrate/frame/src/lib.rs Lines 148 to 149 in 06a68be
|
substrate/frame/src/lib.rs
Outdated
pub use sp_runtime::traits::{IdentifyAccount, IdentityLookup}; | ||
} | ||
|
||
/// Utility traits not tied to any direct operation in the runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Utility traits not tied to any direct operation in the runtime. | |
/// Utility traits not tied to any direct operation in the runtime. | |
/// | |
/// This is already part of the [`prelude`]. |
Cargo.lock
Outdated
@@ -1396,7 +1396,7 @@ dependencies = [ | |||
"futures-lite 2.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all changes to this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you mean? It's on main.
Line 1396 in cccefdd
"futures-lite 2.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix TOML formatting (see https://github.com/paritytech/polkadot-sdk/actions/runs/12758883985/job/35561770915?pr=6599 )
frame-benchmarking = { optional = true, workspace = true } | ||
frame-support = { workspace = true } | ||
frame-system = { workspace = true } | ||
frame = { workspace = true, features = ["experimental", "runtime"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are removing the experimental
feature flag as in #7177 to avoid spreading that feature to the whole sdk.
frame = { workspace = true, features = ["experimental", "runtime"] } | |
frame = { workspace = true, features = ["runtime"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for all open PRs @re-gius
/tip small |
The referendum has appeared on Polkassembly. |
711e6ff
Part of #6504
Added modules
utility
: Traits not tied to any direct operation in the runtime.polkadot address: 14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg