-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ReportCollator message #6628
remove ReportCollator message #6628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove CollatorId
if it is not used anymore? I see a CI job complaining about it.
I can't comment on the exact line - it's 51, the error is shown on the PR (unused import).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Good work @jpserrat! Thank you very much for the contribution. Before merging we need a PRdoc for the pull request. It's a quick description of the changes in the PR which are used to release notes generation. To create it add a file named pr_6628.prdoc (the ID of your PR) to the prdoc subdir in the root of the repo. There you need to explain your changes - what you wrote in the PR is more than enough. You can see an example here - https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_5198.prdoc For your case audience will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @jpserrat
bot fmt |
@tdimitrov https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7811730 was started for your command Comment |
@tdimitrov Command |
41b6915
Closes #6415
Description
Remove unused message
ReportCollator
and test related to this message on the collator protocol validator side.cc: @tdimitrov