Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ReportCollator message #6628

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

jpserrat
Copy link
Contributor

Closes #6415

Description

Remove unused message ReportCollator and test related to this message on the collator protocol validator side.

cc: @tdimitrov

@bkchr bkchr added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Nov 24, 2024
@bkchr bkchr requested a review from tdimitrov November 24, 2024 20:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove CollatorId if it is not used anymore? I see a CI job complaining about it.

I can't comment on the exact line - it's 51, the error is shown on the PR (unused import).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@tdimitrov
Copy link
Contributor

Good work @jpserrat! Thank you very much for the contribution.

Before merging we need a PRdoc for the pull request. It's a quick description of the changes in the PR which are used to release notes generation.

To create it add a file named pr_6628.prdoc (the ID of your PR) to the prdoc subdir in the root of the repo. There you need to explain your changes - what you wrote in the PR is more than enough. You can see an example here - https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_5198.prdoc

For your case audience will be Node Dev and you need to list the crates, changed by your PR (polkadot-collator-protocol and polkadot-node-subsystem-types).

Copy link
Contributor

@tdimitrov tdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @jpserrat

@tdimitrov
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 25, 2024

@tdimitrov https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7811730 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-84607499-7c37-478e-8fc8-4836f01fc363 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 25, 2024

@tdimitrov Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7811730 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7811730/artifacts/download.

@tdimitrov tdimitrov added this pull request to the merge queue Nov 25, 2024
Merged via the queue into paritytech:master with commit 41b6915 Nov 25, 2024
193 of 198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ReportCollator message
3 participants