Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6645 #6656

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6645 into stable2409 from bkontur.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6645-to-stable2409
git worktree add --checkout .worktree/backport-6645-to-stable2409 backport-6645-to-stable2409
cd .worktree/backport-6645-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 1c0b610078611dfebc082be52e77109ea4517e48
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 26, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@bkontur bkontur marked this pull request as ready for review November 26, 2024 16:21
@bkontur bkontur requested review from a team as code owners November 26, 2024 16:21
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove XCMv5 file

Also, please make sure that emulated and unit tests are passing

polkadot/xcm/src/v5/traits.rs Outdated Show resolved Hide resolved
@acatangiu acatangiu enabled auto-merge (squash) November 27, 2024 09:52
@EgorPopelyaev EgorPopelyaev merged commit 603c075 into stable2409 Nov 27, 2024
150 of 185 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6645-to-stable2409 branch November 27, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants