Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Backport #6562 #6700

Open
wants to merge 7 commits into
base: stable2412
Choose a base branch
from

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6562 into stable2412 from re-gius.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6562-to-stable2412
git worktree add --checkout .worktree/backport-6562-to-stable2412 backport-6562-to-stable2412
cd .worktree/backport-6562-to-stable2412
git reset --hard HEAD^
git cherry-pick -x fc315ac5979e9bf1cc56b58ab6f364b6b2689635
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 28, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@re-gius
Copy link
Contributor

re-gius commented Nov 28, 2024

This backport is needed to solve issue polkadot-fellows/runtimes#248 for account nonces and replay attacks without breaking metadata.

@re-gius
Copy link
Contributor

re-gius commented Nov 29, 2024

/cmd prdoc --bump patch --audience runtime_dev

@re-gius re-gius added the R0-silent Changes should not be mentioned in any release notes label Nov 29, 2024
@re-gius re-gius marked this pull request as ready for review November 29, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants