[pallet-broker] add extrinsic to remove a lease

[ethernomad]

Description

#6929 requests more extrinsics for "managing the network's coretime allocations without needing to dabble with migration+runtime upgrade or set/kill storage patterns"

This pull request implements the remove_lease() extrinsic.

Integration

Downstream projects need to benchmark the weight for the remove_lease() extrinsic.

Review Notes

Mentorship is requested to ensure this is implemented correctly.

The lease is removed from state using the TaskId as a key. Is this sufficient. Does the extrinsic need to do anything else?

[bkchr]

Misses a benchmark for remove_lease, otherwise looks good to me.

[seadanda]

Functionality wise, this looks good for this extrinsic.

If somebody wants to do more, for example remove a lease AND remove the associated task from its core in the next sale, they can pair remove_lease with remove_from_workplan (or whatever that extrinsic will be called).

[ethernomad]

bot bench substrate-pallet --pallet=pallet_broker
bot bench cumulus-coretime --pallet=pallet_broker --runtime=coretime-rococo
bot bench cumulus-coretime --pallet=pallet_broker --runtime=coretime-westend

[command-bot]

@ethernomad Requester could not be detected as a member of an allowed organization.

[ethernomad]

Can someone run the bench bot for me?

[re-gius]

bot bench substrate-pallet --pallet=pallet_broker
bot bench cumulus-coretime --pallet=pallet_broker --runtime=coretime-rococo
bot bench cumulus-coretime --pallet=pallet_broker --runtime=coretime-westend

[command-bot]

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966356 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 27-b51ea54a-5117-4dfb-8dfc-0336d89d1cde to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966357 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 28-9a8dd030-225c-4c85-8e84-63823f26f1ff to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@re-gius https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966358 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 29-ed7e8b1e-ea32-42d1-a4a6-92e6526aa487 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --features=riscv --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966356 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966356/artifacts/download.

[command-bot]

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966357 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966357/artifacts/download.

[command-bot]

@re-gius Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_broker has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966358 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7966358/artifacts/download.