Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridges: Remove obsolete relayer CLI args: host, port, path, secure #7549

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rosarp
Copy link
Member

@rosarp rosarp commented Feb 12, 2025

Closes: #7291

Description

Removes obsolete relayer CLI args from bridges and resolves following issue: (#7291)

@rosarp rosarp requested review from bkontur and serban300 February 12, 2025 11:55
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 12, 2025 11:56
@rosarp rosarp added the T15-bridges This PR/Issue is related to bridges. label Feb 12, 2025
@bkontur bkontur added the R0-silent Changes should not be mentioned in any release notes label Feb 12, 2025
@bkontur bkontur assigned bkontur and rosarp and unassigned bkontur Feb 12, 2025
Copy link
Contributor

@serban300 serban300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

We should also take a note in #7291 to update the bridge zombienet tests after a new version of the relayer is published: polkadot-sdk , fellowship/runtimes and also the CI team might need to update the setup for the Polkadot-Kusama relayers.

Also did you run the polkadot-sdk zombienet tests to make sure that they work with this change ? They don't automatically run in the CI, because in the CI we use an older version of the relayer.

@bkontur
Copy link
Contributor

bkontur commented Feb 12, 2025

also the CI team might need to update the setup for the Polkadot-Kusama relayers.

We've checked this already, it uses just uri.

We should also take a note in #7291 to update the bridge zombienet tests after a new version of the relayer is published: polkadot-sdk , fellowship/runtimes

exactly, when we upgrade bridges repo paritytech/parity-bridges-common#3104 + this PR

@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 12, 2025 12:30
@bkontur
Copy link
Contributor

bkontur commented Feb 12, 2025

@rosarp please update also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Bridges: Remove obsolete relayer CLI args: host, port, path, secure
3 participants