Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-informant: Print full hash when debug logging is enabled #7554

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Feb 12, 2025

When debugging stuff, it is useful to see the full hashes and not only the "short form". This makes it easier to read logs and follow blocks.

When debugging stuff, it is useful to see the full hashes and not only the "short form". This makes it easier to read logs and follow blocks.
@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Feb 12, 2025
@bkchr bkchr requested review from skunert and a team February 12, 2025 16:52
Copy link
Contributor

@michalkucharczyk michalkucharczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to get rid of short version, long term maybe?. Looks super nice, but it is nightmare when it comes to debugging and reasoning - simple ctrl-c / ctrl-v not working, ... is preventing from single click searching in most of editors. Not very friendly. (Also different format on info / debug levels makes things a bit more complex when it comes to log parsing / grepping 😕 , different regex for different levels enabled).

@bkchr
Copy link
Member Author

bkchr commented Feb 13, 2025

I'd propose to get rid of short version, long term maybe?.

While I understand your frustration, we need to be aware that the normal info logs are for operators. They don't need to be spammed with ultra long hashes when everything works.

@skunert
Copy link
Contributor

skunert commented Feb 13, 2025

I'd propose to get rid of short version, long term maybe?. Looks super nice, but it is nightmare when it comes to debugging and reasoning - simple ctrl-c / ctrl-v not working, ... is preventing from single click searching in most of editors. Not very friendly. (Also different format on info / debug levels makes things a bit more complex when it comes to log parsing / grepping 😕 , different regex for different levels enabled).

I am a user of the short hashes, IMO much easier to read as human. In my logfile explorer I am always relying on the prefixes and it works just fine. The long hashes make the logs a lot harder to read IMO. See where you guys are coming from, but wanted to present another opinion :P.

@bkchr
Copy link
Member Author

bkchr commented Feb 13, 2025

/cmd prdoc --audience node_dev --bump patch

@bkchr bkchr enabled auto-merge February 13, 2025 11:55
@bkchr bkchr added this pull request to the merge queue Feb 13, 2025
@bkchr
Copy link
Member Author

bkchr commented Feb 13, 2025

I am a user of the short hashes, IMO much easier to read as human.

Me as a user do not want to read them at all :P I just use them as identifiers, which the editor should handle.

Merged via the queue into master with commit 9d14b3b Feb 13, 2025
227 of 232 checks passed
@bkchr bkchr deleted the bkchr-informant-full-hash branch February 13, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants