-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sc-informant: Print full hash when debug logging is enabled #7554
Conversation
When debugging stuff, it is useful to see the full hashes and not only the "short form". This makes it easier to read logs and follow blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose to get rid of short version, long term maybe?. Looks super nice, but it is nightmare when it comes to debugging and reasoning - simple ctrl-c / ctrl-v not working, ...
is preventing from single click searching in most of editors. Not very friendly. (Also different format on info / debug levels makes things a bit more complex when it comes to log parsing / grepping 😕 , different regex for different levels enabled).
While I understand your frustration, we need to be aware that the normal info logs are for operators. They don't need to be spammed with ultra long hashes when everything works. |
I am a user of the short hashes, IMO much easier to read as human. In my logfile explorer I am always relying on the prefixes and it works just fine. The long hashes make the logs a lot harder to read IMO. See where you guys are coming from, but wanted to present another opinion :P. |
/cmd prdoc --audience node_dev --bump patch |
Me as a user do not want to read them at all :P I just use them as identifiers, which the editor should handle. |
When debugging stuff, it is useful to see the full hashes and not only the "short form". This makes it easier to read logs and follow blocks.