[AHM] Poke deposits: Indices pallet #7587
Conversation
UtkarshBhardwaj007
added
T1-FRAME
From what I understand from the code, the |
| /// - `O(1)`. | ||
| #[pallet::call_index(5)] | ||
| #[pallet::weight(T::WeightInfo::reconsider())] | ||
| pub fn reconsider( |
There was a problem hiding this comment.
not because of my own taste, but for the sake of consistency. how about poke_deposit?
we already have for the same purpose poke_deposit in some pallet, and reconsider is the new naming.
There was a problem hiding this comment.
Based this off of @kianenigma 's comment here: #5591 (comment)
There was a problem hiding this comment.
lets wait for @kianenigma opinion. if Kian wants to keep the reconsider anyway, it's also fine by me.
| } else if new_amount < old_amount { | ||
| // Need to unreserve some | ||
| let excess = old_amount.saturating_sub(new_amount); | ||
| T::Currency::unreserve(&who, excess); |
There was a problem hiding this comment.
Could possibly print some defensive failure when it cannot unreserve all, but not big issue.
There was a problem hiding this comment.
What would be the case when we are not able to unreserve the required amount? This arm of if-else would be executed only when the reserved amount > deposit required. So we should always be able to unreserve the amount. Am I missing something here?
There was a problem hiding this comment.
In theory yes, but in practice, sadly no. We do had a few bugs in the past and sometimes it happens that accounts are missing reserves or similar.
Just double-checking this and emitting a defensive! then gives us a hint to when this is happening such that we can investigate manually.
There was a problem hiding this comment.
Ah I see. Will add some logging with defensive!, thanks!
|
Command "--clean" has started 🚀 See logs here |
|
Command "--clean" has finished ✅ See logs here |
Description
reconsidertopallet-indices. This extrinsic will be used to re-adjust the deposits made in the pallet.pokefor Deposits #5591Review Notes
reconsiderinpallet-indices.DepositReconsideredto be emitted upon a successful call of the extrinsic.freeif an actual adjustment is made to the deposit andpaidotherwise.TO-DOs