Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link-checker reloaded #7599

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Fix link-checker reloaded #7599

merged 3 commits into from
Feb 18, 2025

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Feb 18, 2025

One more attempt to fix the link-checker job.

This time we exclude polymesh which is reachable but not via lychee.
Also exclude rust strings that contain "{}" or "{:?}".

@skunert skunert added the R0-silent Changes should not be mentioned in any release notes label Feb 18, 2025
@skunert skunert requested a review from a team February 18, 2025 09:12

# Exclude strings which contain templates like {} and {:?}
"%7B%7D",
"%7B:\\?}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls don't ask me why only the first { is encoded 🤷‍♂️

@skunert skunert enabled auto-merge February 18, 2025 10:35
@skunert skunert added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@skunert skunert enabled auto-merge February 18, 2025 15:19
@skunert skunert added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit d5424fe Feb 18, 2025
248 of 254 checks passed
@skunert skunert deleted the skunert/link-checker-once-more branch February 18, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants