Snowbridge - Removes obsolete test in Outbound Queue v2 #8019
+1
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
added
the
R0-silent
acatangiu
reviewed
Mar 25, 2025
| @@ -140,67 +140,6 @@ fn process_message_fails_on_overweight_message() { | |||
| }) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn governance_message_not_processed_in_same_block_when_queue_congested_with_low_priority_messages() | |||
There was a problem hiding this comment.
why is this test obsolete?
There was a problem hiding this comment.
@acatangiu it is not really relevant anymore, since this test was to ensure that governance messages would be processed first in multi-channel Snowbridge V1. Since any messages can be processed in any order in V2, it is not really relevant. But, to reduce code churn and because the test is passing, I am closing this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is only relevant for Snowbridge v1.
Resolves: SNO-1432