Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagging docker images with release tag instead of commit hash #746

Closed
armin-x86 opened this issue Dec 25, 2023 · 1 comment
Closed

tagging docker images with release tag instead of commit hash #746

armin-x86 opened this issue Dec 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@armin-x86
Copy link

For polkadot-staking-miner, docker images are pushed with this naming convention: branchName-7 characters of the commit SHA
Exp:main-b250ced

As a result of this line in the Job.

If we change the follwing, I think it will fix the issue.

echo IMAGE_TAG=$(if [ -n "$GITHUB_REF_NAME" ]; then echo "$GITHUB_REF_NAME"; else echo "main-${GITHUB_SHA::7}"; fi) >> $GITHUB_ENV
@armin-x86
Copy link
Author

PR

@armin-x86 armin-x86 added the enhancement New feature or request label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants