changing image tag GITHUB_ENV #747
Conversation
| @@ -233,7 +233,7 @@ jobs: | |||
|
|
|||
| - name: Prepare Docker environment | |||
| run: | | |||
| echo IMAGE_TAG=$(if [ "$GITHUB_REF" == "refs/heads/main" ]; then echo "main-${GITHUB_SHA::7}"; else echo "$GITHUB_REF_NAME"; fi) >> $GITHUB_ENV | |||
There was a problem hiding this comment.
The old thingy looks correct to me what's the issue with having commits that isn't released tagged as main-<commit hash>?
I let @sergejparity answer this because I don't understand the issue most likely there is something in the deploy logic that requires a version somewhere? :)
There was a problem hiding this comment.
@arminteimouri change you propose just flips then-else condition. But the result will be the same.
Actually mine solution came from preposition that IMAGE_TAG's like main-xxxxxxx will happen more often and I've put it to the first place.
There was a problem hiding this comment.
The old thingy looks correct to me what's the issue with having commits that isn't released tagged as
main-<commit hash>?
check it – peep the image name, right? That's the key to knowing what version we're running on GKE. But hold up, when you glance at the code, it's like, "What version is this?" 'Cause it's all about the commit hash, and that ain't telling us squat. Sure, we can dive into the repo, track down the commit, find the tag – but why all that hassle? We can keep it chill and just make the version clear from the get-go
There was a problem hiding this comment.
@arminteimouri probably @niklasad1 trying to tell, that this PR actually doesn't change anything apart from sequence of how if condition is evaluated.
it was:
if (push to branch `main`)
IMAGE_TAG="main-xxxxsha"
else
IMAGE_TAG="v0.x.x"
fi
it became:
if (tag pushed)
IMAGE_TAG="v0.x.x"
else
IMAGE_TAG="main-xxxxsha"
fi
That docker image naming logic wasn't introduced by me. I just refactored former GitLab CI into GitHub Action.
There was a problem hiding this comment.
Alright, I see.
We could rename "main-xxxxsha" to "v1.3.0-unstable-xxxxsha" instead, I reckon that would help to understand which version you want to deploy right?
v1.3.0 is the unreleased version in this example and could be parsed from https://github.com/paritytech/polkadot-staking-miner/blob/main/Cargo.toml#L3
There was a problem hiding this comment.
won't that tweak make the pushed Docker image name match the tag and be easy to know which release tag it's linked to?
we got the GITHUB_REF_NAME in the mix, rolling as the image name.
that this PR actually doesn't change anything apart from sequence of how if condition is evaluated
Switching up that sequence does the trick, letting the image tag snag the victory over the main-commitHash name and getting elected as the image name. Correct me please if I'm mistaken.
There was a problem hiding this comment.
We could rename "main-xxxxsha" to "v1.3.0-unstable-xxxxsha" instead,
That make things much clearer and easier to read.
There was a problem hiding this comment.
Switching up that sequence does the trick, letting the
image tagsnag the victory over themain-commitHashname and getting elected as the image name. Correct me please if I'm mistaken.
Not really, this job can distinguish triggering event e.g. push to the main branch in this case "$GITHUB_REF" == "refs/heads/main"
And second case is when tag is pushed.
"$GITHUB_REF" == "refs/tags/vX.X.X"
That's why I'm talking, that you just swapped checks, and they are not overlapping, so order doesn't matter.
|
Closing this as stale and it could be useful but not really a priority for now |
issue #746