Add the multi-batching pallet #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moliholy
force-pushed
the
feature/pallet-multibatching
branch
from
ae7109a to
584abfd
Compare
|
Rebase to latest main branch and fixed formatting errors. |
valentinfernandez1
requested changes
Mar 18, 2024
Moliholy
requested changes
Mar 18, 2024
gupnik
reviewed
Mar 19, 2024
Moliholy
reviewed
Mar 25, 2024
niksaak
force-pushed
the
feature/pallet-multibatching
branch
from
a67ae30 to
0cd85cf
Compare
…to feature/pallet-multibatching
Moliholy
reviewed
Apr 18, 2024
Moliholy
reviewed
Apr 18, 2024
|
Note: Got a really weird test failure here https://github.com/paritytech/project-mythical/pull/7/files#diff-f32c6058a961ae704009f331f11355de75895fb1291ab2892e1bc9954495f489R714 in the latest commit. Success where there should be an "Invalid Transaction" error. Doesn't reproduce locally. |
|
Tests passed on re-try. Possibly the reason for the previous failure was very lucky key generation in tests. |
|
Please run |
Moliholy
approved these changes
Apr 25, 2024
valentinfernandez1
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Multibatching pallet to support batching calls from multiple callers, approved off-chain, in a single extrinsic. Documentation / tests / benchmarks included. The weights file was generated on a local machine.