-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update subwasm dependency to 0.19 #60
Conversation
Co-authored-by: Chevdor <[email protected]>
Sorry, I probably made a bigger deal than it was 😄 I reverted to only change the subwasm value. All good now. |
@chevdor I guess it can be merged now 😁 |
When can I expect a Docker image with this fix to be released? |
When the next release is finalized :) |
@chevdor we kind of need this feature in rather sooner than later, and would like to avoid building our own image. There is no breaking change since subwasm is retro-compatible. Would it make sense to have a patch release with this change in? |
One of the goal of
While building your own image would be an option, I would recommend against it as users could no longer use the canonical version of Instead, I can think of 2 options and the later is IMO the best: Swap
|
@chevdor I see there are few images with a tag structure of, for instance, |
## fixes KILTprotocol/ticket#2241 Generates metadata and publishes json value to s3 bucket Sample here https://kilt-protocol.org/peregrine/peregrine-metadata.json ## Pending - [x] SRTool Docker image that includes the new subwasm 0.19 with support for `json+scale` output format. PR: paritytech/srtool#60 --------- Co-authored-by: Tino Rusch <[email protected]> Co-authored-by: Antonio <[email protected]>
## fixes KILTprotocol/ticket#2241 Generates metadata and publishes json value to s3 bucket Sample here https://kilt-protocol.org/peregrine/peregrine-metadata.json ## Pending - [x] SRTool Docker image that includes the new subwasm 0.19 with support for `json+scale` output format. PR: paritytech/srtool#60 --------- Co-authored-by: Tino Rusch <[email protected]> Co-authored-by: Antonio <[email protected]>
Since the new subwasm version includes a feature we need, this PR bumps the subwasm dependency to the newly released version 0.19 which includes this feature.