-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip metadata fix #1774
Merged
Merged
Strip metadata fix #1774
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8e0743a
WIP: one more bug
pkhry e9ae53b
size diff examples
pkhry 7d12589
ready for review
pkhry 1ea2068
toml formatting
pkhry 78a3d8c
Merge branch 'master' into pkhry/metadata_stripping
jsdw 00a18ab
review comments
pkhry 3baf555
Merge branch 'master' into pkhry/metadata_stripping
pkhry e5b1c82
clippy
pkhry da32fab
review comments
pkhry cdfe63f
review comments
pkhry 7e0cb69
review comments
pkhry 6786c02
Merge branch 'master' into pkhry/metadata_stripping
pkhry 7e063dc
review comments
pkhry 292bec4
review comment
pkhry 4275bc5
clippy
pkhry c5d1787
review comments
pkhry 2c41564
clippy
pkhry 8f28a7d
review comments
pkhry 5732dc1
Update metadata/src/utils/retain.rs
pkhry 35c43a2
review comments
pkhry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather create a dev-note using
//
to avoid this to end-up in the API docs