Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

add try-runtime github workflow #245

Merged
merged 21 commits into from
Jul 27, 2023
Merged

Conversation

brunopgalvao
Copy link
Contributor

@brunopgalvao brunopgalvao commented Jun 29, 2023

In alignment with #197

  • Check that the try-runtime feature builds
    • We do not need this check on every PR. If anything the try-runtime feature will fail when it runs with the migration label
  • Run try-runtime on PRs marked with a migration label

@brunopgalvao brunopgalvao self-assigned this Jun 29, 2023
@brunopgalvao brunopgalvao added the migration This pull request has a storage migration label Jun 30, 2023
@brunopgalvao brunopgalvao added this to the Trappist M2 / XCM v3 milestone Jun 30, 2023
@brunopgalvao brunopgalvao added migration This pull request has a storage migration and removed migration This pull request has a storage migration labels Jul 3, 2023
@brunopgalvao brunopgalvao added migration This pull request has a storage migration and removed migration This pull request has a storage migration labels Jul 3, 2023
@brunopgalvao
Copy link
Contributor Author

brunopgalvao commented Jul 4, 2023

So I need feedback on which way to move forward. Currently, with this PR, we have it configured so that when we mark a PR with the migration label, it will kick off try-runtime for that PR and test the migration - this is currently how the FRAME team does it. However, they are moving away from this, to a more secure approach by running try-runtime on every commit of every PR regardless of the migration label:

Is this something that we would like to do as well?

From my point of view, having try-runtime kick off on the migration label is good enough for our purposes. If we want an added layer of reassurance we could additionally run try-runtime when we create a "draft" for the release (it would serve as a catch-all).

.github/workflows/check.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
@brunopgalvao brunopgalvao added migration This pull request has a storage migration and removed migration This pull request has a storage migration labels Jul 15, 2023
@brunopgalvao brunopgalvao added migration This pull request has a storage migration and removed migration This pull request has a storage migration labels Jul 15, 2023
@brunopgalvao
Copy link
Contributor Author

We also want this workflow to run on subsequent pushes.

@brunopgalvao brunopgalvao added migration This pull request has a storage migration and removed migration This pull request has a storage migration labels Jul 17, 2023
@brunopgalvao brunopgalvao added migration This pull request has a storage migration and removed migration This pull request has a storage migration labels Jul 17, 2023
@brunopgalvao brunopgalvao removed the migration This pull request has a storage migration label Jul 20, 2023
@brunopgalvao brunopgalvao added the migration This pull request has a storage migration label Jul 20, 2023
@stiiifff stiiifff merged commit fea97ed into main Jul 27, 2023
@stiiifff stiiifff deleted the bruno-try-runtime-github-workflow branch July 27, 2023 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
migration This pull request has a storage migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants