You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 21, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I need feedback on which way to move forward. Currently, with this PR, we have it configured so that when we mark a PR with the migration label, it will kick off try-runtime for that PR and test the migration - this is currently how the FRAME team does it. However, they are moving away from this, to a more secure approach by running try-runtime on every commit of every PR regardless of the migration label:
Is this something that we would like to do as well?
From my point of view, having try-runtime kick off on the migration label is good enough for our purposes. If we want an added layer of reassurance we could additionally run try-runtime when we create a "draft" for the release (it would serve as a catch-all).
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
migrationThis pull request has a storage migration
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In alignment with #197
Check that the try-runtime feature buildsmigration
labelmigration
label