Release 0.9.42 to main. #250

hbulgarini · 2023-07-20T14:45:42Z

upgrade polkadot release codebase to 0.9.42
upgrade rust toolchain to nightly-2023-05-22
upgrade weights to use from_parts constructor instead of temporary from_ref_time

next steps after merge:

* Upgraded to 9-40 missing some fixes * Added XCM v3 Traits (Need to configure) * Added fee per MB * Added XCM V3 Configs * Fix XCM_config and node service * Removed chess pallet * pallet_contracts and pallet_xcm fix * rust fmt * Quick fix to contracts on stout and pallet-dex dependancie * Added hardware check to service * Fixed stout service * Review fixes * run tests on CI (#174) (cherry picked from commit d826938) * fmt * review fix * review fix * fmt * Fixed xcm-playground error --------- Co-authored-by: Valentin Fernandez <[email protected]> Co-authored-by: Alexander Kalankhodzhaev <[email protected]>

Backport PR #165 (cherry picked from commit 3f1c483) in Trappist v0.9.40 and updates it to match the changes included in polkadot v0.9.38 to v0.9.40. Weights were re benchmarked to match weightsV2. --------- Co-authored-by: Valentin Fernandez <[email protected]>

Backport PR #173 (cherry picked from commit 24552f3) in Trappist v0.9.40 and updates it to match the changes included in polkadot v0.9.38 to v0.9.40. Weights were re benchmarked to match weightsV2. Co-authored-by: Valentin Fernandez <[email protected]>

* zombienet refactor and ci fix * swap-storage removed from CI * ci fix * CI fix --------- Co-authored-by: Valentin Fernandez <[email protected]>

* lockdown-pallet backport * Add lockdown mode activation to lockdown-mode pallet's `GenesisConfig` (#176) * add activating lockdown mode to GenesisConfig * add activating lockdown mode to test ext * add tests for activating lockdown mode in GenesisConfig * cargo fmt -p pallet-lockdown-mode * fix linting * add activated to benchmark * removing, as this is already in another test * setting initial state to true, therefore no longer need to manually change state * rename activated in genesisConfig to initial_status --------- Co-authored-by: Valentin Fernandez <[email protected]> Co-authored-by: Bruno Galvao <[email protected]>

#201) * backport xcm_benchmarks * Co-Authored-By: hbulgarini <[email protected]> * fix * add profile "production" (#187) --------- Co-authored-by: Alexander Kalankhodzhaev <[email protected]>

…209) * cherry-picked changes * WIP fixing node service¨ * Upgrade fixes, missing stout trait bound error * workspace refactor * added dex to stout * fmt --------- Co-authored-by: Hector Bulgarini <[email protected]>

* query_account_balances added * fmt * Added assets-common dependency from Cumulus --------- Co-authored-by: Steve Degosserie <[email protected]>

* backport apache license * backport minor refactoring PR #223 * fmt

* Removed FixedRateOfFungibles * fmt * added comments * fmt * removed unused imports * fmt * removed allow unpaid execution from rockmine following PR #211 * Include new traders from PR #221 * minor fixes * minor fixes * fmt

…arks (#229) * Validate `MultiLocation` for asset-registry (#224) * Validate location for register_reserve_asset * fmt * fmt * fmt * validator refactor * fmt * fix `pallet_xcm_benchmarks::generic::claim_asset` benchmark (#226) * Bump docker/login-action from 2.1.0 to 2.2.0 (#219) Bumps [docker/login-action](https://github.com/docker/login-action) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@f4ef78c...465a078) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/metadata-action from 4.4.0 to 4.5.0 (#218) Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@c4ee3ad...2c0bd77) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix network id in tests * fix network id in tests * Add missing import * include preimage to benchmarks * Bump docker/metadata-action from 4.5.0 to 4.6.0 (#233) Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@2c0bd77...818d4b7) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump docker/build-push-action from 4.0.0 to 4.1.1 (#232) Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.0.0 to 4.1.1. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@3b5e802...2eb1c19) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alexander Kalankhodzhaev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Cargo.toml

.github/templates/setup-worker/action.yaml

node/src/service.rs

pallets/asset-registry/src/tests.rs

runtime/trappist/src/constants.rs

runtime/trappist/src/impls.rs

runtime/trappist/src/lib.rs

templates/xcm-bench-template.hbs

kalaninja · 2023-07-24T15:04:05Z

I was also curious why you changed MaxCodeLen and CallStack in pallet_contracts::Config and probably is worth mentioning this pr containing information on where these numbers come from, what they affect and how they can be adjusted.

valentinfernandez1 · 2023-07-24T15:54:58Z

I was also curious why you changed MaxCodeLen and CallStack in pallet_contracts::Config and probably is worth mentioning this pr containing information on where these numbers come from, what they affect and how they can be adjusted.

This also comes from the update to v0.9.40, and it follows paritytech/cumulus#2108

.github/templates/free-space/action.yaml

valentinfernandez1 · 2023-07-24T16:03:22Z

runtime/trappist/src/lib.rs

 	type MaxReserves = ConstU32<50>;
 	type ReserveIdentifier = [u8; 8];
+	type HoldIdentifier = ();
+	type FreezeIdentifier = ();
+	type MaxHolds = ConstU32<0>;


Is it okey that we keep this values at ConstU32<0>?. Not completely sure what would be the best alternative

I think currently construct_runtime macro generates RuntimeFreezeReason and RuntimeHoldReason enums based on #[pallet::composite_enum] attributes in pallets. These should be used as ***Identifiers here.
As freezes are the new locks and reserves were deprecated in favor of holds I think the corresponding limits can be reused.
See:

Deprecate Currency; introduce holds and freezing into fungible traits substrate#12951

https://github.com/paritytech/substrate/blob/master/frame/support/procedural/src/construct_runtime/expand/hold_reason.rs

https://github.com/paritytech/substrate/blob/master/frame/support/procedural/src/construct_runtime/expand/freeze_reason.rs

But anyway this is not critical for the migration and can be addressed in a separate pr.

… in the asset-hub

valentinfernandez1 · 2023-07-26T18:01:57Z

Just added the fix to WeightsToFee. The commit also includes some formatting fixes.

hbulgarini · 2023-07-30T12:51:30Z

@kalaninja we are ready to merge right ?

runtime/trappist/src/xcm_config.rs

Cargo.toml

stiiifff · 2023-07-31T09:57:22Z

LGTM 🚀️

valentinfernandez1 and others added 14 commits May 19, 2023 11:01

asset-registry backport (#193)

d4e4fb8

Backport PR #173 (cherry picked from commit 24552f3) in Trappist v0.9.40 and updates it to match the changes included in polkadot v0.9.38 to v0.9.40. Weights were re benchmarked to match weightsV2. Co-authored-by: Valentin Fernandez <[email protected]>

fix CI for substrate version update (#198)

141571e

Backport Zombienet and CI testing (#194)

7ee2415

* zombienet refactor and ci fix * swap-storage removed from CI * ci fix * CI fix --------- Co-authored-by: Valentin Fernandez <[email protected]>

[Backport] #185 XCM benchmarks from pallet_xcm_benchmarks to v0.9.40 (

16d1480

#201) * backport xcm_benchmarks * Co-Authored-By: hbulgarini <[email protected]> * fix * add profile "production" (#187) --------- Co-authored-by: Alexander Kalankhodzhaev <[email protected]>

Query account balances using accounts_common (#202)

855f102

* query_account_balances added * fmt * Added assets-common dependency from Cumulus --------- Co-authored-by: Steve Degosserie <[email protected]>

[Backport] #220 Apache License and #223 Minor Refactoring (#228)

00f7621

* backport apache license * backport minor refactoring PR #223 * fmt

Refactor WeightToFee to include ProofSize (#215)

85b9903

* Removed FixedRateOfFungibles * fmt * added comments * fmt * removed unused imports * fmt * removed allow unpaid execution from rockmine following PR #211 * Include new traders from PR #221 * minor fixes * minor fixes * fmt

WIP

c61e5fd

Compiling version of polkadot v0.9.42

dfd267b

hbulgarini requested a review from kalaninja July 20, 2023 14:45

kalaninja reviewed Jul 24, 2023

View reviewed changes

valentinfernandez1 reviewed Jul 24, 2023

View reviewed changes

.github/templates/free-space/action.yaml Outdated Show resolved Hide resolved

valentinfernandez1 reviewed Jul 24, 2023

View reviewed changes

WeightToFee updated to use FeePolynomial. Based on the implementation…

043969a

… in the asset-hub

kalaninja marked this pull request as ready for review July 30, 2023 02:24

kalaninja requested review from stiiifff, valentinfernandez1 and kalaninja July 30, 2023 02:44

finish upgrade

cddc10f

kalaninja force-pushed the hb-xcmv3-dev-0.9.42 branch from 1842886 to cddc10f Compare July 30, 2023 02:45

stiiifff suggested changes Jul 30, 2023

View reviewed changes

runtime/trappist/src/xcm_config.rs Show resolved Hide resolved

Cargo.toml Show resolved Hide resolved

kalaninja and others added 2 commits July 31, 2023 01:49

update deps

7079df5

Addressing check account

41d7721

hbulgarini requested a review from stiiifff July 31, 2023 07:20

hbulgarini added 2 commits July 31, 2023 09:40

Fix

61c6f09

fmt

b79fbb4

stiiifff approved these changes Jul 31, 2023

View reviewed changes

hbulgarini merged commit f378496 into main Jul 31, 2023
4 checks passed

hbulgarini deleted the hb-xcmv3-dev-0.9.42 branch July 31, 2023 10:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 0.9.42 to main. #250

Release 0.9.42 to main. #250

hbulgarini commented Jul 20, 2023 •

edited

Loading

kalaninja commented Jul 24, 2023

valentinfernandez1 commented Jul 24, 2023

valentinfernandez1 Jul 24, 2023 •

edited

Loading

kalaninja Jul 25, 2023

valentinfernandez1 commented Jul 26, 2023 •

edited

Loading

hbulgarini commented Jul 30, 2023

stiiifff commented Jul 31, 2023

Release 0.9.42 to main. #250

Release 0.9.42 to main. #250

Conversation

hbulgarini commented Jul 20, 2023 • edited Loading

kalaninja commented Jul 24, 2023

valentinfernandez1 commented Jul 24, 2023

valentinfernandez1 Jul 24, 2023 • edited Loading

Choose a reason for hiding this comment

kalaninja Jul 25, 2023

Choose a reason for hiding this comment

valentinfernandez1 commented Jul 26, 2023 • edited Loading

hbulgarini commented Jul 30, 2023

stiiifff commented Jul 31, 2023

hbulgarini commented Jul 20, 2023 •

edited

Loading

valentinfernandez1 Jul 24, 2023 •

edited

Loading

valentinfernandez1 commented Jul 26, 2023 •

edited

Loading