Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/lazy evaluation #27

Merged
merged 10 commits into from
Jun 23, 2024
Merged

Feature/lazy evaluation #27

merged 10 commits into from
Jun 23, 2024

Commits on Jun 22, 2024

  1. Factor in limit when check_ingredients_only_in_top_select is True 

    benchmarks run, but need to add some tests to be sure this works correctly (i.e. we're passing the right number of values)
    @parkervg
    parkervg committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    335c67a View commit details
    Browse the repository at this point in the history

  2. remove unused MODIFIERS variable 

    Now, we just use `isinstance(node, exp.Predicate)`
    @parkervg
    parkervg committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    6abf009 View commit details
    Browse the repository at this point in the history

  3. to_select_star() function

    @parkervg
    parkervg committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    8bdef6d View commit details
    Browse the repository at this point in the history

  4. test_apply_limit for 335c67a

    @parkervg
    parkervg committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    78eae30 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/lazy-evaluation

    @parkervg
    parkervg committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b2f0c2f View commit details
    Browse the repository at this point in the history

  6. test_apply_limit_with_predicate for 335c67a

    @parkervg
    parkervg committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    d4022e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Normalize like clauses by calling LOWER

    @parkervg
    parkervg committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    70e6983 View commit details
    Browse the repository at this point in the history

  2. Handle case when abstracted_df comes from a JOIN

    @parkervg
    parkervg committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    be5c72a View commit details
    Browse the repository at this point in the history

  3. Modify test case

    @parkervg
    parkervg committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    0a5f764 View commit details
    Browse the repository at this point in the history

  4. Simplify check_ingredients_only_in_top_select optimization 

    Before, we had a mess of sqlglot logic if it so happened that we had a join clause
    @parkervg
    parkervg committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    58af67f View commit details
    Browse the repository at this point in the history