Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a translation in Indonesian language to the documentation #14

Merged
merged 12 commits into from
Oct 3, 2020
Merged

Adding a translation in Indonesian language to the documentation #14

merged 12 commits into from
Oct 3, 2020

Conversation

fritssasia
Copy link
Contributor

@fritssasia fritssasia commented Oct 2, 2020

Hello I am frits sasia, this is the result of my contribution. I added a translation for documentation in Indonesian language
I hope this can help and make it easier for people who are not fluent in English

The changes I made :

  1. I created a doc-translation folder
  2. I created a README-IND.md file which contains a translation of this documentation in Indonesian language
  3. I edited the README.md original documentation file by adding a dropdown menu which lists the languages available for this documentation (allowing users to read documentation in other languages) and added info about the doc-translation folder in the project structure section.

I will try to invite my friends, maybe someone is interested for contributing here
I hope you like it, thank you :)

ref.: #36

Copy link
Owner

@parksb parksb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :D

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@parksb
Copy link
Owner

parksb commented Oct 3, 2020

LGTM. Thank you!

@fritssasia
Copy link
Contributor Author

By the way, does the README-IND.md file need to add a dropdown menu for the available language options? as in the README.md file

@parksb parksb merged commit 4e2e856 into parksb:master Oct 3, 2020
@fritssasia
Copy link
Contributor Author

LGTM. Thank you!

You're welcome, thank you also for accepting me to contribute to this repository

@parksb
Copy link
Owner

parksb commented Oct 3, 2020

By the way, does the README-IND.md file need to add a dropdown menu for the available language options? as in the README.md file

I don't think you have to, but if you have time, please send a new PR 😉

@parksb parksb added the documentation Improvements or additions to documentation label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants