Add section to configure when operator full knative

[gabriel-farache]

Closes https://issues.redhat.com/browse/FLPATH-1406
Add section to configure when operator full knative

Related to parodos-dev/serverless-workflows-config#375

[gabriel-farache]

/hold until apache/incubator-kie-kogito-serverless-operator#467 is merged and chart is updated with operator version with the feature

[masayag]

We agreed not incorporate the Kafka related configuration into the chart, but perhaps patching the sonataflowplatform can be considered, WDYT?

[masayag]

Since the entire orchestrator chart is designed for OCP (there is another one for k8s), I'd try to remain as closer as possible to the formal OCP admin guides.
Are the following steps fits with the recommendation in the OCP admin guide?

[gabriel-farache]

WDYM? You do not like the wording For that, you will need: ?

[gabriel-farache]

Is that better?

[masayag]

I was referring only to the steps to configure Kafka as a broker of knative eventing.

[gabriel-farache]

ah, ok
So, is that better now?

[masayag]

My intention was to provide a link to https://docs.openshift.com/serverless/1.33/eventing/brokers/kafka-broker.html which is the official admin guide for openshift serverless instead of relying on the upstream doc.
Mainly since we are opinionated about the version of the openshift serverless operators installed by the chart.

[gabriel-farache]

I added the link to this doc in step 2 when we create the broker

But I think we still need to install the eventing resources we install at step 1, not sure if everything is installed with the operator

[gabriel-farache]

@masayag

We agreed not incorporate the Kafka related configuration into the chart, but perhaps patching the sonataflowplatform can be considered

What is related to kafka that should be in the sonataflowplatform? In the readme, we are already patching it for the broker: https://github.com/parodos-dev/orchestrator-helm-chart/pull/207/files#diff-75c29d9ec0c1a79cafdacdbbebff3ea3fa3d649f1b43440783208b21845238dcR61-R76

[masayag]

@masayag

We agreed not incorporate the Kafka related configuration into the chart, but perhaps patching the sonataflowplatform can be considered

What is related to kafka that should be in the sonataflowplatform? In the readme, we are already patching it for the broker: https://github.com/parodos-dev/orchestrator-helm-chart/pull/207/files#diff-75c29d9ec0c1a79cafdacdbbebff3ea3fa3d649f1b43440783208b21845238dcR61-R76

I was trying to explore the option to incorporate this patch into the orchestrator chart, but we can start without having it included.

[gabriel-farache]

was trying to explore the option to incorporate this patch into the orchestrator chart, but we can start without having it included.

The issue here is that the broker name depends on the user
We could also include all the steps to the orchestrator directly (installing the knative resource for kafka, creating and configuring the kafka broker and patchin the sonataflowplateform) if the user asks for it

But that should be another issue

[masayag]

pls reopen this PR in https://github.com/parodos-dev/orchestrator-helm-operator

[masayag]

@gabriel-farache this PR needs to be closed and reopened against https://github.com/parodos-dev/orchestrator-helm-operator

[gabriel-farache]

@masayag I know I know, it's on my TODO list, but it's not top priority as the PR is still in progress

[gabriel-farache]

@masayag , there I did it, now we have 0 PR on this repo :)

[masayag]

@masayag , there I did it, now we have 0 PR on this repo :)

thanks @gabriel-farache, now there are also 0 issues ;-)