-
Notifications
You must be signed in to change notification settings - Fork 26
[FLPATH-294] Return Checkers in WorkFlowDefinitions #463
[FLPATH-294] Return Checkers in WorkFlowDefinitions #463
Conversation
62d27dc
to
79c68e3
Compare
...vice/src/main/java/com/redhat/parodos/workflow/definition/dto/WorkDefinitionResponseDTO.java
Outdated
Show resolved
Hide resolved
...vice/src/main/java/com/redhat/parodos/workflow/definition/dto/WorkDefinitionResponseDTO.java
Outdated
Show resolved
Hide resolved
e604ad8
to
ba7fdcf
Compare
hi @gabriel-farache , can you please attach an example of new workflow definition response in comments/description? this change will be critical for th UI display(we don't show checkers in UI, so @dagda1 needs to know how to ignore it from the new response). Thank you |
@RichardW98 @dagda1
|
/lgtm |
ba7fdcf
to
7f71ca6
Compare
/lgtm |
@gabriel-farache please rebase |
7f71ca6
to
063958f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anludke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, when WorkFlowDefinition are requested (
/api/v1/workflowdefinitions
), the checkers associated to tasks are not returned.This PR introduces changes so those checkers are returned.
The way the work units of each WorfFlowDefinition are built has been refactored (see
WorkFlowDefinitionServiceImpl
)Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):Fixes #FLPATH-294
Change type
Impacted services
Checklist