This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Fix unit tests for GetApplicationTask #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gciavarrini
changed the title
`GetApplicationTask` add `applicationID` paramenter as a String not as an Integer. Signed-off-by: Gloria Ciavarrini <[email protected]>
Signed-off-by: Gloria Ciavarrini <[email protected]>
gciavarrini
force-pushed
the
fix-test-get-app-task
branch
from
1c5026b
to
5cb7ea4
Compare
This was referenced Aug 8, 2023
Signed-off-by: Gloria Ciavarrini <[email protected]>
gciavarrini
force-pushed
the
fix-test-get-app-task
branch
from
5cb7ea4
to
a49781a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix and re-enabled
GetApplicationTaskTestthat was disabled in PR #493To fix the tests, it was necessary to convert
appIDfrominttoStringto match the current implementation.Which issue(s) this PR fixes:
Fixes: Partially fixes test disabled in PR #493
Change type
Impacted services
Checklist