Fix upstream warnings under Elixir 1.16 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is hitting us as well, and the blocking error here looks trivial (the PR contains an extra set of double params in one location). Any chance I can entice y'all to get this over the line? |
|
I'm very sorry being late to take action. Thank you for the PR 🙇. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for Elixir 1.16, this pull request fixes missing empty parentheses warnings for function calls without arguments. This change is crucial in addressing a new behavior in Elixir, as detailed in Elixir issue #13091. Previously, omitting parentheses in such function calls in ExVCR would generate warnings only when compiling ExVCR itself. However, with Elixir 1.16, these warnings have become upstream warnings. This means they now also appear when compiling code that uses ExVCR, especially in modules that
use ExVCR.Mock. So, this affects essentially all ExVCR users and is particularly problematic for those employing the--warnings-as-errorsflag in their CI environments, which is quite common.While I was at it, I removed all such warnings (i.e. also outside of macros).