-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Bump AGP from 7.1.3 to 8.5.2 #1213
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
ee1773a
to
2793182
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is upgrading AGP a breaking change, or does that only affect how the SDK itself is built?
It is not a breaking change, it only changes the build tools. |
Could you resolve the conflict, so we can merge this? Edit: tried to resolve the conflicts, waiting for CI... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! LGTM!
New Pull Request Checklist
Issue Description
Current AndroidGradlePlugin is 7.1.3.
Closes: #1212.
Approach
Upgrade AGP and gradle-wrapper and modify code syntax accordingly.
TODOs before merging