Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Bump AGP from 7.1.3 to 8.5.2 #1213

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

refactor: Bump AGP from 7.1.3 to 8.5.2 #1213

wants to merge 8 commits into from

Conversation

abubkr-hago
Copy link

New Pull Request Checklist

Issue Description

Current AndroidGradlePlugin is 7.1.3.

Closes: #1212.

Approach

Upgrade AGP and gradle-wrapper and modify code syntax accordingly.

TODOs before merging

  • No tests required.
  • No documentation changes required.

@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Aug 17, 2024 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza mentioned this pull request Aug 17, 2024
Closed
4 tasks
mtrezza
mtrezza reviewed Aug 17, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is upgrading AGP a breaking change, or does that only affect how the SDK itself is built?

@abubkr-hago
Copy link
Author

Is upgrading AGP a breaking change, or does that only affect how the SDK itself is built?

It is not a breaking change, it only changes the build tools.
Updating these dependencies allows the use of JDK_17 which is faster than JDK_11 and has more features.

@mtrezza
Copy link
Member

mtrezza commented Oct 5, 2024 •
edited
Loading

Could you resolve the conflict, so we can merge this?

Edit: tried to resolve the conflicts, waiting for CI...

azlekov
azlekov approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@azlekov azlekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! LGTM!

@mtrezza mtrezza closed this Oct 31, 2024
@mtrezza mtrezza reopened this Oct 31, 2024
@mtrezza mtrezza mentioned this pull request Oct 31, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza left review comments

@azlekov azlekov azlekov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade AGP and gradle-wrapper
3 participants
@abubkr-hago @mtrezza @azlekov