-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update setup instructions in README for current Android Studio #1198
Conversation
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you take a final look, I did some refactoring.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1198 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 122 122
Lines 9971 9971
Branches 1345 1345
======================================
Misses 9971 9971 ☔ View full report in Codecov by Sentry. |
Looks good, I'd say go ahead and merge if it's good with you. |
🎉 This change has been released in version 4.2.1 |
Issue Description
The Getting Started instruction in the README file were out of date for the current versions of Android Studio. For newer Android Studio projects created in Android Studio Bumblebee | 2021.1.1 or newer, the JitPack repository needs to be added into the root level file settings.gradle instead of build.gradle.
Closes: #1197
Approach
Edited the README.md file to reflect current steps required to setup a new Android Studio project.
TODOs before merging