Skip to content

Conversation

swittk
Copy link
Contributor

@swittk swittk commented Sep 20, 2025

Pull Request

Issue

FetchOptions should be an optional parameter same as before the V6 changes. The ObjectController downstream already handles this parameter as optional.

Closes: #2725

Approach

Adds the optionality to the typescript type.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

FetchOptions should be an optional parameter same as before the V6 changes. The ObjectController downstream already handles this parameter as optional.
Copy link

parse-github-assistant bot commented Sep 20, 2025

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@swittk swittk changed the title Update ParseObject.ts Types : Update ParseObject.ts Sep 20, 2025
@swittk swittk changed the title Types : Update ParseObject.ts fix : Update ParseObject.ts Sep 20, 2025
@swittk swittk changed the title fix : Update ParseObject.ts fix: Update ParseObject.ts Sep 20, 2025
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6941012) to head (47d7f21).

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2726   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6185      6185           
  Branches      1472      1456   -16     
=========================================
  Hits          6185      6185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza changed the title fix: Update ParseObject.ts fix: Incorrect type in ParseObject.fetch parameter options Sep 21, 2025
@mtrezza
Copy link
Member

mtrezza commented Sep 21, 2025

Could you please take a look at https://github.com/parse-community/Parse-SDK-JS/blob/alpha/CONTRIBUTING.md#typescript-tests for type modifications to fix the failing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse.Object fetch() incorrect type.
3 participants