-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build using Github Actions #35
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 185 187 +2
Branches 26 28 +2
=========================================
+ Hits 185 187 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@dplewis can you review this when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we want to release this as an official product. The last significant commit was made >2 years ago, so we'd first need to make sure this is up-to-date regarding security fixes, etc. We'd also have to add release automation, because it'd be too inefficient to manually maintain this "non-core" repo. Maybe we even need to generally review this, no sure whether this was ever intended to be released as an official product.
There are ongoing discussions that could lead to archiving this repo. Regarding its original purpose, I think it makes more sense to use a 3rd party perf testing tool, it seems to me we're reinventing the wheel here.
Moves the CI to Github Actions.